]> git.baikalelectronics.ru Git - kernel.git/commit
dmaengine: pl330: Fix lockdep warning about non-static key
authorDmitry Osipenko <dmitry.osipenko@collabora.com>
Fri, 20 May 2022 18:14:32 +0000 (21:14 +0300)
committerVinod Koul <vkoul@kernel.org>
Wed, 6 Jul 2022 05:19:28 +0000 (10:49 +0530)
commit989d8ffa2393b3e9954d6f84538faf78e13d8ef8
treedd6c76371b5e6de6deff1440b3622d73dd032e11
parent8cdaf05c12b82092a2774a0ad816dae9f0e6eacd
dmaengine: pl330: Fix lockdep warning about non-static key

The DEFINE_SPINLOCK() macro shouldn't be used for dynamically allocated
spinlocks. The lockdep warns about this and disables locking validator.
Fix the warning by making lock static.

 INFO: trying to register non-static key.
 The code is fine but needs lockdep annotation, or maybe
 you didn't initialize this object before use?
 turning off the locking correctness validator.
 Hardware name: Radxa ROCK Pi 4C (DT)
 Call trace:
  dump_backtrace.part.0+0xcc/0xe0
  show_stack+0x18/0x6c
  dump_stack_lvl+0x8c/0xb8
  dump_stack+0x18/0x34
  register_lock_class+0x4a8/0x4cc
  __lock_acquire+0x78/0x20cc
  lock_acquire.part.0+0xe0/0x230
  lock_acquire+0x68/0x84
  _raw_spin_lock_irqsave+0x84/0xc4
  add_desc+0x44/0xc0
  pl330_get_desc+0x15c/0x1d0
  pl330_prep_dma_cyclic+0x100/0x270
  snd_dmaengine_pcm_trigger+0xec/0x1c0
  dmaengine_pcm_trigger+0x18/0x24
  ...

Fixes: 7e8f0af911ae ("dmaengine: pl330: fix descriptor allocation fail")
Signed-off-by: Dmitry Osipenko <dmitry.osipenko@collabora.com>
Link: https://lore.kernel.org/r/20220520181432.149904-1-dmitry.osipenko@collabora.com
Signed-off-by: Vinod Koul <vkoul@kernel.org>
drivers/dma/pl330.c