]> git.baikalelectronics.ru Git - kernel.git/commit
rfkill: fix rfkill_fop_read wait_event usage
authorJohannes Berg <johannes.berg@intel.com>
Tue, 26 Jan 2016 10:29:03 +0000 (11:29 +0100)
committerJohannes Berg <johannes.berg@intel.com>
Tue, 26 Jan 2016 10:32:05 +0000 (11:32 +0100)
commit984e17716d1329e023de84c16f5f1f27edb527e5
tree744a387ea6c9555b197842db8e87cd538ddfc958
parent7ff757a8d00ccb1bfcbc0840bf630c5f07ea9dd4
rfkill: fix rfkill_fop_read wait_event usage

The code within wait_event_interruptible() is called with
!TASK_RUNNING, so mustn't call any functions that can sleep,
like mutex_lock().

Since we re-check the list_empty() in a loop after the wait,
it's safe to simply use list_empty() without locking.

This bug has existed forever, but was only discovered now
because all userspace implementations, including the default
'rfkill' tool, use poll() or select() to get a readable fd
before attempting to read.

Cc: stable@vger.kernel.org
Fixes: 1a9205955c9b4 ("rfkill: create useful userspace interface")
Reported-by: Dmitry Vyukov <dvyukov@google.com>
Signed-off-by: Johannes Berg <johannes.berg@intel.com>
net/rfkill/core.c