]> git.baikalelectronics.ru Git - kernel.git/commit
net: pcs: xpcs: depends on PHYLINK in Kconfig
authorJakub Kicinski <kuba@kernel.org>
Thu, 23 Jun 2022 20:29:33 +0000 (13:29 -0700)
committerJakub Kicinski <kuba@kernel.org>
Sat, 25 Jun 2022 05:49:22 +0000 (22:49 -0700)
commit9834b1bab995357ee0d8bcc48312fd7211542151
treece6b14ead141c4c513f93ba3360723c85ad8dbb2
parent409458d7e4554bc9dbe132bf72fafe7ac10ad506
net: pcs: xpcs: depends on PHYLINK in Kconfig

This is yet another attempt at fixing:

>> ERROR: modpost: "phylink_mii_c22_pcs_encode_advertisement" [drivers/net/pcs/pcs_xpcs.ko] undefined!
>> ERROR: modpost: "phylink_mii_c22_pcs_decode_state" [drivers/net/pcs/pcs_xpcs.ko] undefined!

Switch XPCS to be invisible, as Russell points out it's
"selected" by its consumers. Drop the dependency on MDIO_BUS
as "depends" is meaningless on "selected" symbols.

Reported-by: kernel test robot <lkp@intel.com>
Fixes: 481730fda404 ("net: pcs: xpcs: add CL37 1000BASE-X AN support")
Link: https://lore.kernel.org/netdev/20220620201915.1195280-1-kuba@kernel.org/
Link: https://lore.kernel.org/r/20220622083521.0de3ea5c@kernel.org/
Link: https://lore.kernel.org/r/20220623202933.2341938-1-kuba@kernel.org
Signed-off-by: Jakub Kicinski <kuba@kernel.org>
drivers/net/pcs/Kconfig