]> git.baikalelectronics.ru Git - kernel.git/commit
usb: phy: isp1301-omap: fix smatch warnings
authorAaro Koskinen <aaro.koskinen@iki.fi>
Sat, 21 Dec 2013 18:37:37 +0000 (20:37 +0200)
committerFelipe Balbi <balbi@ti.com>
Mon, 23 Dec 2013 16:14:40 +0000 (10:14 -0600)
commit9802d32e64e424d7ea6fd1bcf1872d5b459a7a4a
tree96489433d85ed9ad655bdc2419f0cc8516bda47b
parente6c010a7ab0660da93b9dc4f0cf0d0155745cb97
usb: phy: isp1301-omap: fix smatch warnings

phy-isp1301-omap produces the following smatch warnings:

drivers/usb/phy/phy-isp1301-omap.c:1280 isp1301_set_host() warn: variable dereferenced before check 'otg' (see line 1278)
drivers/usb/phy/phy-isp1301-omap.c:1336 isp1301_set_peripheral() warn: variable dereferenced before check 'otg' (see line 1334)
drivers/usb/phy/phy-isp1301-omap.c:1417 isp1301_start_srp() warn: variable dereferenced before check 'otg' (see line 1414)
drivers/usb/phy/phy-isp1301-omap.c:1445 isp1301_start_hnp() warn: variable dereferenced before check 'otg' (see line 1442)

Fix by deleting bogus NULL pointer checks. The USB framework will always
call us with a valid OTG pointer.

Signed-off-by: Aaro Koskinen <aaro.koskinen@iki.fi>
Signed-off-by: Felipe Balbi <balbi@ti.com>
drivers/usb/phy/phy-isp1301-omap.c