]> git.baikalelectronics.ru Git - kernel.git/commit
drm/i915: Fix enabled_planes bitmask
authorVille Syrjälä <ville.syrjala@linux.intel.com>
Fri, 5 Mar 2021 15:36:05 +0000 (17:36 +0200)
committerVille Syrjälä <ville.syrjala@linux.intel.com>
Mon, 22 Mar 2021 15:55:25 +0000 (17:55 +0200)
commit97bc7ffa1b1e9a8672e0a8e9a96680b0c3717427
tree59b4701ab1f63ffd469d1bc90b5ffc852387608b
parent3a913fa535c185d017625b352a32d1643d1f489e
drm/i915: Fix enabled_planes bitmask

The enabled_planes bitmask was supposed to track logically enabled
planes (ie. fb!=NULL and crtc!=NULL), but instead we end up putting
even disabled planes into the bitmask since
intel_plane_atomic_check_with_state() only takes the early exit
if the plane was disabled and stays disabled. I think I misread
the early said codepath to exit whenever the plane is logically
disabled, which is not true.

So let's fix this up properly and set the bit only when the plane
actually is logically enabled.

Cc: Manasi Navare <manasi.d.navare@intel.com>
Fixes: ee42ec19ca2e ("drm/i915: Track logically enabled planes for hw state")
Signed-off-by: Ville Syrjälä <ville.syrjala@linux.intel.com>
Link: https://patchwork.freedesktop.org/patch/msgid/20210305153610.12177-2-ville.syrjala@linux.intel.com
Reviewed-by: Manasi Navare <manasi.d.navare@intel.com>
drivers/gpu/drm/i915/display/intel_atomic_plane.c