]> git.baikalelectronics.ru Git - kernel.git/commit
tcp: fix tp->undo_retrans accounting in tcp_sacktag_one()
authorzhenggy <zhenggy@chinatelecom.cn>
Tue, 14 Sep 2021 01:51:15 +0000 (09:51 +0800)
committerGreg Kroah-Hartman <gregkh@linuxfoundation.org>
Wed, 22 Sep 2021 10:26:42 +0000 (12:26 +0200)
commit97a6c6d880c657557092daa3401873f19fed9697
tree096c41c641c5c6f296ec09563d0568a62126f539
parent3eaa487bbeac5548580fa9ab2a7f07cf402fae76
tcp: fix tp->undo_retrans accounting in tcp_sacktag_one()

commit 4f884f3962767877d7aabbc1ec124d2c307a4257 upstream.

Commit c24f111438b4 ("tcp-tso: do not split TSO packets at retransmit
time") may directly retrans a multiple segments TSO/GSO packet without
split, Since this commit, we can no longer assume that a retransmitted
packet is a single segment.

This patch fixes the tp->undo_retrans accounting in tcp_sacktag_one()
that use the actual segments(pcount) of the retransmitted packet.

Before that commit (c24f111438b4), the assumption underlying the
tp->undo_retrans-- seems correct.

Fixes: c24f111438b4 ("tcp-tso: do not split TSO packets at retransmit time")
Signed-off-by: zhenggy <zhenggy@chinatelecom.cn>
Reviewed-by: Eric Dumazet <edumazet@google.com>
Acked-by: Yuchung Cheng <ycheng@google.com>
Acked-by: Neal Cardwell <ncardwell@google.com>
Signed-off-by: David S. Miller <davem@davemloft.net>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
net/ipv4/tcp_input.c