]> git.baikalelectronics.ru Git - kernel.git/commit
bridge: vlan: use rcu list for the ordered vlan list
authorNikolay Aleksandrov <nikolay@cumulusnetworks.com>
Fri, 2 Oct 2015 13:05:10 +0000 (15:05 +0200)
committerDavid S. Miller <davem@davemloft.net>
Sun, 4 Oct 2015 23:43:47 +0000 (16:43 -0700)
commit970dd378ac945171ffb3b8a93140df4ced216bde
tree8b59c375f2861840765f7915987ecf9e15e85bdf
parent6966bfd88a13f63458e705529827c913c5f0b62e
bridge: vlan: use rcu list for the ordered vlan list

When I did the conversion to rhashtable I missed the required locking of
one important user of the vlan list - br_get_link_af_size_filtered()
which is called:
br_ifinfo_notify() -> br_nlmsg_size() -> br_get_link_af_size_filtered()
and the notifications can be sent without holding rtnl. Before this
conversion the function relied on using rcu and since we already use rcu to
destroy the vlans, we can simply migrate the list to use the rcu helpers.

Signed-off-by: Nikolay Aleksandrov <nikolay@cumulusnetworks.com>
Signed-off-by: David S. Miller <davem@davemloft.net>
net/bridge/br_netlink.c
net/bridge/br_vlan.c