]> git.baikalelectronics.ru Git - kernel.git/commit
Merge branch 'cbq-fixes'
authorDavid S. Miller <davem@davemloft.net>
Tue, 19 Aug 2014 17:59:12 +0000 (10:59 -0700)
committerDavid S. Miller <davem@davemloft.net>
Tue, 19 Aug 2014 17:59:12 +0000 (10:59 -0700)
commit96dd9d2196c1ea649eeb45363139d6e9a336e89a
treea199e218bf0b0603bd71ebe7a74d14a4f54c7bbf
parent2d4e3e881114ecffba2c7a62d31a3dc1742af02a
parenta7ef8cba1dc222929747fccd4319eb4326ca9f87
Merge branch 'cbq-fixes'

Vasily Averin says:

====================
cbq: incorrectly low bandwidth blocks limited traffic

v2: patch description changes
Fixes: 78021ca1039a ("cbq: incorrect processing of high limits")
Mainstream commit 78021ca1039a ("cbq: incorrect processing of high limits")
have side effect: if cbq bandwidth setting is less than real interface
throughput non-limited traffic can delay limited traffic for a very long time.

This happen because of q->now changes incorrectly in cbq_dequeue():
in described scenario L2T is much greater than real time delay,
and q->now gets an extra boost for each transmitted packet.

Accumulated boost prevents update q->now, and blocked class can wait
very long time until (q->now >= cl->undertime) will be true again.

More detailed problem description can be found here:
http://www.spinics.net/lists/netdev/msg292493.html

Following patches should fix the problem.
====================

Signed-off-by: David S. Miller <davem@davemloft.net>