]> git.baikalelectronics.ru Git - kernel.git/commit
53c700: fix BUG on untagged commands
authorJames Bottomley <jejb@linux.vnet.ibm.com>
Tue, 14 Jun 2016 05:00:07 +0000 (22:00 -0700)
committerMartin K. Petersen <martin.petersen@oracle.com>
Wed, 15 Jun 2016 01:17:22 +0000 (21:17 -0400)
commit96c6f23736d4c51a01224d2122aa75a0a6601485
tree987be35122c11d6a30b0c4076fa81a02d4fde356
parent8edeeb715ade4d1d241c8766e3402d10a6ea7de0
53c700: fix BUG on untagged commands

The untagged command case in the 53c700 driver has been broken since
host wide tags were enabled because the replaced scsi_find_tag()
function had a special case for the tag value SCSI_NO_TAG to retrieve
sdev->current_cmnd.  The replacement function scsi_host_find_tag() has
no such special case and returns NULL causing untagged commands to
trigger a BUG() in the driver.  Inspection shows that the 53c700 is the
only driver using this SCSI_NO_TAG case, so a local fix in the driver
suffices to fix this problem globally.

Fixes: 9705c9206ad - "scsi: use host wide tags by default"
Cc: stable@vger.kernel.org # 4.4+
Reported-by: Helge Deller <deller@gmx.de>
Tested-by: Helge Deller <deller@gmx.de>
Signed-off-by: James Bottomley <jejb@linux.vnet.ibm.com>
Reviewed-by: Johannes Thumshirn <jthumshirn@suse.de>
Reviewed-by: Ewan D. Milne <emilne@redhat.com>
Acked-by: Christoph Hellwig <hch@lst.de>
Signed-off-by: Martin K. Petersen <martin.petersen@oracle.com>
drivers/scsi/53c700.c