]> git.baikalelectronics.ru Git - kernel.git/commit
nbd: make the config put is called before the notifying the waiter
authorXiubo Li <xiubli@redhat.com>
Wed, 14 Oct 2020 02:45:14 +0000 (22:45 -0400)
committerJens Axboe <axboe@kernel.dk>
Wed, 14 Oct 2020 18:30:37 +0000 (12:30 -0600)
commit9630c3167c26c7d99187c7a32c79e93ac9b60c4a
tree609f0e7c0b09ecb0b0912127aef79f3ff784aa68
parentcaad74db9ea6d28c11857c667bd51884ae24ce21
nbd: make the config put is called before the notifying the waiter

There has one race case for ceph's rbd-nbd tool. When do mapping
it may fail with EBUSY from ioctl(nbd, NBD_DO_IT), but actually
the nbd device has already unmaped.

It dues to if just after the wake_up(), the recv_work() is scheduled
out and defers calling the nbd_config_put(), though the map process
has exited the "nbd->recv_task" is not cleared.

Signed-off-by: Xiubo Li <xiubli@redhat.com>
Reviewed-by: Josef Bacik <josef@toxicpanda.com>
Signed-off-by: Jens Axboe <axboe@kernel.dk>
drivers/block/nbd.c