]> git.baikalelectronics.ru Git - kernel.git/commit
arm64: alternatives: Move length validation in alternative_{insn, endif}
authorNathan Chancellor <nathan@kernel.org>
Wed, 14 Apr 2021 00:08:04 +0000 (17:08 -0700)
committerCatalin Marinas <catalin.marinas@arm.com>
Thu, 15 Apr 2021 17:33:25 +0000 (18:33 +0100)
commit95d14243743d764e6b3b2e2ab9cf6c3ffd171129
treed6be89f7456097ad3afed89d35a419ddefef27fe
parente208e2d9bb5d1fb9589ed9542ed48188bd0903e1
arm64: alternatives: Move length validation in alternative_{insn, endif}

After commit 3c9652edccf6 ("arm64: mte: Ensure TIF_MTE_ASYNC_FAULT is
set atomically"), LLVM's integrated assembler fails to build entry.S:

<instantiation>:5:7: error: expected assembly-time absolute expression
 .org . - (664b-663b) + (662b-661b)
      ^
<instantiation>:6:7: error: expected assembly-time absolute expression
 .org . - (662b-661b) + (664b-663b)
      ^

The root cause is LLVM's assembler has a one-pass design, meaning it
cannot figure out these instruction lengths when the .org directive is
outside of the subsection that they are in, which was changed by the
.arch_extension directive added in the above commit.

Apply the same fix from commit 4bf14e31bafd ("arm64/alternatives: move
length validation inside the subsection") to the alternative_endif
macro, shuffling the .org directives so that the length validation
happen will always happen in the same subsections. alternative_insn has
not shown any issue yet but it appears that it could have the same issue
in the future so just preemptively change it.

Fixes: f0702046de6e ("arm64/alternatives: use subsections for replacement sequences")
Cc: <stable@vger.kernel.org> # 5.8.x
Link: https://github.com/ClangBuiltLinux/linux/issues/1347
Signed-off-by: Nathan Chancellor <nathan@kernel.org>
Reviewed-by: Sami Tolvanen <samitolvanen@google.com>
Tested-by: Sami Tolvanen <samitolvanen@google.com>
Reviewed-by: Nick Desaulniers <ndesaulniers@google.com>
Tested-by: Nick Desaulniers <ndesaulniers@google.com>
Link: https://lore.kernel.org/r/20210414000803.662534-1-nathan@kernel.org
Signed-off-by: Catalin Marinas <catalin.marinas@arm.com>
arch/arm64/include/asm/alternative-macros.h