]> git.baikalelectronics.ru Git - kernel.git/commit
ALSA: pcm: oss: Remove WARNING from snd_pcm_plug_alloc() checks
authorTakashi Iwai <tiwai@suse.de>
Thu, 12 Mar 2020 15:57:30 +0000 (16:57 +0100)
committerTakashi Iwai <tiwai@suse.de>
Thu, 12 Mar 2020 15:58:03 +0000 (16:58 +0100)
commit9503ca886e0007ac43d15aeaf3350b479a6d6b8b
tree0e676c61f56ef8aa3c0a469fcb092125a6cb1196
parent0f52828ec81687886a0bbda257ce11bb480addfb
ALSA: pcm: oss: Remove WARNING from snd_pcm_plug_alloc() checks

The return value checks in snd_pcm_plug_alloc() are covered with
snd_BUG_ON() macro that may trigger a kernel WARNING depending on the
kconfig.  But since the error condition can be triggered by a weird
user space parameter passed to OSS layer, we shouldn't give the kernel
stack trace just for that.  As it's a normal error condition, let's
remove snd_BUG_ON() macro usage there.

Reported-by: syzbot+2a59ee7a9831b264f45e@syzkaller.appspotmail.com
Cc: <stable@vger.kernel.org>
Link: https://lore.kernel.org/r/20200312155730.7520-1-tiwai@suse.de
Signed-off-by: Takashi Iwai <tiwai@suse.de>
sound/core/oss/pcm_plugin.c