]> git.baikalelectronics.ru Git - kernel.git/commit
platform/x86/intel: pmc/core: change pmc_lpm_modes to static
authorTom Rix <trix@redhat.com>
Sat, 23 Apr 2022 12:30:48 +0000 (08:30 -0400)
committerHans de Goede <hdegoede@redhat.com>
Wed, 27 Apr 2022 14:50:25 +0000 (16:50 +0200)
commit94f8938e5b1d085ffb878da29d5e165b9b8a23b0
tree891d257161098559fc40056bc88c9233790971f6
parent04bd20b614352a587e463b0324d8dbd70c5b551a
platform/x86/intel: pmc/core: change pmc_lpm_modes to static

Sparse reports this issue
core.c: note: in included file:
core.h:239:12: warning: symbol 'pmc_lpm_modes' was not declared. Should it be static?

Global variables should not be defined in headers.  This only works
because core.h is only included by core.c. Single file use
variables should be static, so change its storage-class specifier
to static.

Signed-off-by: Tom Rix <trix@redhat.com>
Reviewed-by: David E. Box <david.e.box@linux.intel.com>
Link: https://lore.kernel.org/r/20220423123048.591405-1-trix@redhat.com
Signed-off-by: Hans de Goede <hdegoede@redhat.com>
drivers/platform/x86/intel/pmc/core.h