]> git.baikalelectronics.ru Git - kernel.git/commit
cpufreq: qcom-kryo: Fix section annotations
authorNathan Chancellor <natechancellor@gmail.com>
Thu, 20 Sep 2018 00:22:21 +0000 (17:22 -0700)
committerRafael J. Wysocki <rafael.j.wysocki@intel.com>
Sat, 29 Sep 2018 13:01:10 +0000 (15:01 +0200)
commit939b7d062f81428118a13fd3def530937818df97
tree47374cdf51a1ac66d32b5ccd537900733485d241
parentcf80c873e685c0440e4b1c448412449c7a97917a
cpufreq: qcom-kryo: Fix section annotations

There is currently a warning when building the Kryo cpufreq driver into
the kernel image:

WARNING: vmlinux.o(.text+0x8aa424): Section mismatch in reference from
the function qcom_cpufreq_kryo_probe() to the function
.init.text:qcom_cpufreq_kryo_get_msm_id()
The function qcom_cpufreq_kryo_probe() references
the function __init qcom_cpufreq_kryo_get_msm_id().
This is often because qcom_cpufreq_kryo_probe lacks a __init
annotation or the annotation of qcom_cpufreq_kryo_get_msm_id is wrong.

Remove the '__init' annotation from qcom_cpufreq_kryo_get_msm_id
so that there is no more mismatch warning.

Additionally, Nick noticed that the remove function was marked as
'__init' when it should really be marked as '__exit'.

Fixes: b293b8403885 (cpufreq: Add Kryo CPU scaling driver)
Fixes: 27b03aaa508b (cpufreq: kryo: Add module remove and exit)
Reported-by: Nick Desaulniers <ndesaulniers@google.com>
Signed-off-by: Nathan Chancellor <natechancellor@gmail.com>
Acked-by: Viresh Kumar <viresh.kumar@linaro.org>
Cc: 4.18+ <stable@vger.kernel.org> # 4.18+
Signed-off-by: Rafael J. Wysocki <rafael.j.wysocki@intel.com>
drivers/cpufreq/qcom-cpufreq-kryo.c