]> git.baikalelectronics.ru Git - kernel.git/commit
dmaengine: imx-sdma: Fix a possible memory leak in sdma_transfer_init
authorHui Wang <hui.wang@canonical.com>
Wed, 30 Nov 2022 09:08:00 +0000 (17:08 +0800)
committerGreg Kroah-Hartman <gregkh@linuxfoundation.org>
Mon, 6 Feb 2023 06:52:48 +0000 (07:52 +0100)
commit93660a30e233359c77db19a6553bf59c6a0795c9
treecc9e01953a47fe30b2db29a5e0e5aac8fd21bacf
parent017781fa952cf42c69314f1bd1514ce5e82313d9
dmaengine: imx-sdma: Fix a possible memory leak in sdma_transfer_init

[ Upstream commit 1417f59ac0b02130ee56c0c50794b9b257be3d17 ]

If the function sdma_load_context() fails, the sdma_desc will be
freed, but the allocated desc->bd is forgot to be freed.

We already met the sdma_load_context() failure case and the log as
below:
[ 450.699064] imx-sdma 30bd0000.dma-controller: Timeout waiting for CH0 ready
...

In this case, the desc->bd will not be freed without this change.

Signed-off-by: Hui Wang <hui.wang@canonical.com>
Reviewed-by: Sascha Hauer <s.hauer@pengutronix.de>
Link: https://lore.kernel.org/r/20221130090800.102035-1-hui.wang@canonical.com
Signed-off-by: Vinod Koul <vkoul@kernel.org>
Signed-off-by: Sasha Levin <sashal@kernel.org>
drivers/dma/imx-sdma.c