]> git.baikalelectronics.ru Git - kernel.git/commit
drm/dp_mst: Fix return code on sideband message failure
authorRajkumar Subbiah <rsubbia@codeaurora.org>
Tue, 6 Jul 2021 15:30:34 +0000 (08:30 -0700)
committerLyude Paul <lyude@redhat.com>
Tue, 27 Jul 2021 22:58:28 +0000 (18:58 -0400)
commit92bd92c44d0d9be5dcbcda315b4be4b909ed9740
treefbc08c8b0dab0ad6c6935b9fd4da369286f1d836
parent5e23c98178eb1a2cdb7c4fee9a39baf8cabf282d
drm/dp_mst: Fix return code on sideband message failure

Commit 2f015ec6eab6 ("drm/dp_mst: Add sideband down request tracing +
selftests") added some debug code for sideband message tracing. But
it seems to have unintentionally changed the behavior on sideband message
failure. It catches and returns failure only if DRM_UT_DP is enabled.
Otherwise it ignores the error code and returns success. So on an MST
unplug, the caller is unaware that the clear payload message failed and
ends up waiting for 4 seconds for the response. Fixes the issue by
returning the proper error code.

Changes in V2:
-- Revise commit text as review comment
-- add Fixes text

Changes in V3:
-- remove "unlikely" optimization

Fixes: 2f015ec6eab6 ("drm/dp_mst: Add sideband down request tracing + selftests")
Cc: <stable@vger.kernel.org> # v5.5+
Signed-off-by: Rajkumar Subbiah <rsubbia@codeaurora.org>
Signed-off-by: Kuogee Hsieh <khsieh@codeaurora.org>
Reviewed-by: Stephen Boyd <swboyd@chromium.org>
Reviewed-by: Jani Nikula <jani.nikula@intel.com>
Reviewed-by: Lyude Paul <lyude@redhat.com>
Signed-off-by: Lyude Paul <lyude@redhat.com>
Link: https://patchwork.freedesktop.org/patch/msgid/1625585434-9562-1-git-send-email-khsieh@codeaurora.org
drivers/gpu/drm/drm_dp_mst_topology.c