]> git.baikalelectronics.ru Git - kernel.git/commit
mlxsw: core_acl_flex_actions: Remove redundant mirror resource destruction
authorNir Dotan <nird@mellanox.com>
Fri, 3 Aug 2018 12:57:44 +0000 (15:57 +0300)
committerDavid S. Miller <davem@davemloft.net>
Fri, 3 Aug 2018 19:28:01 +0000 (12:28 -0700)
commit9215feb9fe70116e43a221f1abc6fe6a1455f412
treeefe603173134e9aa9dda6043038d0d22edf6b454
parentaa957fbd9caf4e461aba2e0f6c79cfc94cdb835f
mlxsw: core_acl_flex_actions: Remove redundant mirror resource destruction

In previous patch mlxsw_afa_resource_del() was added to avoid a duplicate
resource detruction scenario.
For mirror actions, such duplicate destruction leads to a crash as in:

 # tc qdisc add dev swp49 ingress
 # tc filter add dev swp49 parent ffff: \
   protocol ip chain 100 pref 10 \
   flower skip_sw dst_ip 192.168.101.1 action drop
 # tc filter add dev swp49 parent ffff: \
   protocol ip pref 10 \
   flower skip_sw dst_ip 192.168.101.1 action goto chain 100 \
   action mirred egress mirror dev swp4

Therefore add a call to mlxsw_afa_resource_del() in
mlxsw_afa_mirror_destroy() in order to clear that resource
from rule's resources.

Fixes: 0e04e02f7c46 ("mlxsw: spectrum_acl: Add support for mirror action")
Signed-off-by: Nir Dotan <nird@mellanox.com>
Reviewed-by: Jiri Pirko <jiri@mellanox.com>
Signed-off-by: Ido Schimmel <idosch@mellanox.com>
Signed-off-by: David S. Miller <davem@davemloft.net>
drivers/net/ethernet/mellanox/mlxsw/core_acl_flex_actions.c