]> git.baikalelectronics.ru Git - kernel.git/commit
net: netcp: Do not clobber PHY link outside of state machine
authorFlorian Fainelli <f.fainelli@gmail.com>
Mon, 6 Feb 2017 23:55:22 +0000 (15:55 -0800)
committerDavid S. Miller <davem@davemloft.net>
Tue, 7 Feb 2017 18:48:22 +0000 (13:48 -0500)
commit921350a0bfa743ca5dad75829cb04ff750e701fc
treef92c9a882d166f68b2e5b4fd88c0af1d3cbdcad0
parent7fc9c122770d61a8d8542824cf69f7404447a302
net: netcp: Do not clobber PHY link outside of state machine

Calling phy_read_status() means that we may call into
genphy_read_status() which in turn will use genphy_update_link() which
can make changes to phydev->link outside of the state machine's state
transitions. This is an invalid behavior that is now caught as off
fb35200345ae ("phy state machine: failsafe leave invalid RUNNING state")

Signed-off-by: Florian Fainelli <f.fainelli@gmail.com>
Signed-off-by: David S. Miller <davem@davemloft.net>
drivers/net/ethernet/ti/netcp_ethss.c