]> git.baikalelectronics.ru Git - kernel.git/commit
ALSA: hda/cs8409: change cs8409_fixups v.pins initializers to static
authorTom Rix <trix@redhat.com>
Mon, 4 Jul 2022 14:28:36 +0000 (10:28 -0400)
committerTakashi Iwai <tiwai@suse.de>
Tue, 5 Jul 2022 07:45:21 +0000 (09:45 +0200)
commit91d8abe8d067a85b96b12c172119bf0f92ea7c00
treef3848b7e5820a49140c27f65aa68d3a2cfdbaa73
parentb6c705a71910324f2a6583889f5f552a00f37e36
ALSA: hda/cs8409: change cs8409_fixups v.pins initializers to static

sparse reports
sound/pci/hda/patch_cs8409-tables.c:79:25: warning: symbol 'cs8409_cs42l42_pincfgs_no_dmic' was not declared. Should it be static?

cs8409_cs42l42_pincfgs_no_dmic is only used by cs8409_fixups table as an
initializer for the hda_fixup element v.pins.  Both are defined in the
patch_cs8408-table.c file but only cs8409_fixups is used externally in
patch_cs8409.c.  So cs8409_cs42l42_pincfgs_no_dmic should have a static
storage class specifier.

The other v.pins initializers in cs8409_fixups table, though declared
extern in patch_cs8409.h are also only used in patch_cs8409-tables.c.
So change all the v.pins initializers to static.

Fixes: 88cc2b89c1ae ("ALSA: hda/cs8409: Move arrays of configuration to a new file")
Signed-off-by: Tom Rix <trix@redhat.com>
Link: https://lore.kernel.org/r/20220704142836.636204-1-trix@redhat.com
Signed-off-by: Takashi Iwai <tiwai@suse.de>
sound/pci/hda/patch_cs8409-tables.c
sound/pci/hda/patch_cs8409.h