]> git.baikalelectronics.ru Git - kernel.git/commit
xen-netback: fix a BUG() during initialization
authorPalik, Imre <imrep@amazon.de>
Fri, 19 Jun 2015 12:21:51 +0000 (14:21 +0200)
committerDavid S. Miller <davem@davemloft.net>
Tue, 23 Jun 2015 10:34:02 +0000 (03:34 -0700)
commit91d5b4eae611c82a1e1f9a0bc8833d6d2ca8b358
tree27923ea28478e5becfc6a226beddee2b9b71cc31
parent7495227cf6159863fb688bec9365342c8ca7b0fb
xen-netback: fix a BUG() during initialization

Commit 3bf449bbfd8a ("xen-netback: making the bandwidth limiter runtime settable")
introduced the capability to change the bandwidth rate limit at runtime.
But it also introduced a possible crashing bug.

If netback receives two XenbusStateConnected without getting the
hotplug-status watch firing in between, then it will try to register the
watches for the rate limiter again.  But this triggers a BUG() in the watch
registration code.

The fix modifies connect() to remove the possibly existing packet-rate
watches before trying to install those watches.  This behaviour is in line
with how connect() deals with the hotplug-status watch.

Signed-off-by: Imre Palik <imrep@amazon.de>
Cc: Matt Wilson <msw@amazon.com>
Acked-by: Wei Liu <wei.liu2@citrix.com>
Signed-off-by: David S. Miller <davem@davemloft.net>
drivers/net/xen-netback/xenbus.c