]> git.baikalelectronics.ru Git - kernel.git/commit
can: j1939: j1939_sk_queue_activate_next_locked(): replace WARN_ON_ONCE with netdev_w...
authorFedor Pchelkin <pchelkin@ispras.ru>
Fri, 29 Jul 2022 14:36:55 +0000 (17:36 +0300)
committerMarc Kleine-Budde <mkl@pengutronix.de>
Tue, 9 Aug 2022 07:05:06 +0000 (09:05 +0200)
commit91c8451e462ce9645cce21056a3cb430939dba78
tree3dd62149c949b849d06b817847331e927ded6da7
parent381aa4f9f75e89e4ef4eb76d7d7d83fb252ca408
can: j1939: j1939_sk_queue_activate_next_locked(): replace WARN_ON_ONCE with netdev_warn_once()

We should warn user-space that it is doing something wrong when trying
to activate sessions with identical parameters but WARN_ON_ONCE macro
can not be used here as it serves a different purpose.

So it would be good to replace it with netdev_warn_once() message.

Found by Linux Verification Center (linuxtesting.org) with Syzkaller.

Fixes: c4da2dabb66d ("can: add support of SAE J1939 protocol")
Signed-off-by: Fedor Pchelkin <pchelkin@ispras.ru>
Signed-off-by: Alexey Khoroshilov <khoroshilov@ispras.ru>
Acked-by: Oleksij Rempel <o.rempel@pengutronix.de>
Link: https://lore.kernel.org/all/20220729143655.1108297-1-pchelkin@ispras.ru
[mkl: fix indention]
Signed-off-by: Marc Kleine-Budde <mkl@pengutronix.de>
net/can/j1939/socket.c