]> git.baikalelectronics.ru Git - kernel.git/commit
net/mlx4_core: clean up cq_res_start_move_to()
authorPaul Bolle <pebolle@tiscali.nl>
Tue, 14 Jan 2014 19:45:36 +0000 (20:45 +0100)
committerDavid S. Miller <davem@davemloft.net>
Fri, 17 Jan 2014 00:04:47 +0000 (16:04 -0800)
commit91950c9f5db7065c2c2cdd2457949b8659647dc1
treec4f15b039e9411b0860d7ff5ee9f9af82bdae0a3
parent152ce0f5646d17d1b363e191daad24a6ca157da7
net/mlx4_core: clean up cq_res_start_move_to()

Building resource_tracker.o triggers a GCC warning:
    drivers/net/ethernet/mellanox/mlx4/resource_tracker.c: In function 'mlx4_HW2SW_CQ_wrapper':
    drivers/net/ethernet/mellanox/mlx4/resource_tracker.c:3019:16: warning: 'cq' may be used uninitialized in this function [-Wmaybe-uninitialized]
      atomic_dec(&cq->mtt->ref_count);
                    ^

This is a false positive. But a cleanup of cq_res_start_move_to() can
help GCC here. The code currently uses a switch statement where an
if/else construct would do too, since only two of the switch's four
cases can ever occur. Dropping that switch makes the warning go away.

While we're at it, add some missing braces.

Signed-off-by: Paul Bolle <pebolle@tiscali.nl>
Signed-off-by: David S. Miller <davem@davemloft.net>
drivers/net/ethernet/mellanox/mlx4/resource_tracker.c