]> git.baikalelectronics.ru Git - kernel.git/commit
drm/i915: Nuke skl_update_plane debug message from the pipe update critical section
authorMaarten Lankhorst <maarten.lankhorst@linux.intel.com>
Wed, 8 Mar 2017 12:00:07 +0000 (13:00 +0100)
committerJani Nikula <jani.nikula@intel.com>
Mon, 13 Mar 2017 15:30:26 +0000 (17:30 +0200)
commit915b2192375632f8a6d6c3df6ab0ab7ae1e30676
tree4640f6029dfeca7c98cc33585647ac1bb69afe65
parent03f258397dfdd7fa86b4ba2d93e19ae50efb2938
drm/i915: Nuke skl_update_plane debug message from the pipe update critical section

printks are slow so we should not be doing them from the vblank evade
critical section. These could explain why we sometimes seem to
blow past our 100 usec deadline.

The problem has been there ever since commit 876853ecfd40 ("drm/i915:
skylake sprite plane scaling using shared scalers.") but it may not have
been readily visible until commit e1edbd44e23b ("drm/i915: Complain
if we take too long under vblank evasion.") increased our chances
of noticing it.

Signed-off-by: Maarten Lankhorst <maarten.lankhorst@linux.intel.com>
Cc: Ville Syrjälä <ville.syrjala@linux.intel.com>
Link: http://patchwork.freedesktop.org/patch/msgid/1488974407-25175-1-git-send-email-maarten.lankhorst@linux.intel.com
Fixes: 876853ecfd40 ("drm/i915: skylake sprite plane scaling using shared scalers")
Cc: <stable@vger.kernel.org> # v4.2+
Reviewed-by: Ville Syrjälä <ville.syrjala@linux.intel.com>
[mlankhorst: Add missing tags, point to the correct offending commit]
(cherry picked from commit d38146b9ee16264ff9a88bf3391ab9f2f5af3646)
Signed-off-by: Jani Nikula <jani.nikula@intel.com>
drivers/gpu/drm/i915/intel_sprite.c