]> git.baikalelectronics.ru Git - kernel.git/commit
i2c: robotfuzz-osif: fix control-request directions
authorJohan Hovold <johan@kernel.org>
Mon, 24 May 2021 09:09:12 +0000 (11:09 +0200)
committerWolfram Sang <wsa@kernel.org>
Thu, 24 Jun 2021 20:08:00 +0000 (22:08 +0200)
commit913fdec44a901e3075508f335099e5779ecc3ba5
tree31cf0d52c78ee2a6e7069c31e6051e8577c366ff
parentcd2d7a70785606a78f79acb7b8f1be9c2931ecd8
i2c: robotfuzz-osif: fix control-request directions

The direction of the pipe argument must match the request-type direction
bit or control requests may fail depending on the host-controller-driver
implementation.

Control transfers without a data stage are treated as OUT requests by
the USB stack and should be using usb_sndctrlpipe(). Failing to do so
will now trigger a warning.

Fix the OSIFI2C_SET_BIT_RATE and OSIFI2C_STOP requests which erroneously
used the osif_usb_read() helper and set the IN direction bit.

Reported-by: syzbot+9d7dadd15b8819d73f41@syzkaller.appspotmail.com
Fixes: f4ecf148e545 ("i2c: Add bus driver for for OSIF USB i2c device.")
Cc: stable@vger.kernel.org # 3.14
Signed-off-by: Johan Hovold <johan@kernel.org>
Signed-off-by: Wolfram Sang <wsa@kernel.org>
drivers/i2c/busses/i2c-robotfuzz-osif.c