]> git.baikalelectronics.ru Git - kernel.git/commit
firmware: dmi_scan: Fix UUID length safety check
authorJean Delvare <jdelvare@suse.de>
Fri, 13 Apr 2018 13:37:59 +0000 (15:37 +0200)
committerJean Delvare <jdelvare@suse.de>
Fri, 13 Apr 2018 13:37:59 +0000 (15:37 +0200)
commit90fe6f8ff00a07641ca893d64f75ca22ce77cca2
treec472ca195b90ec429c8b70997eb6d6638f6cd3c2
parent0adb32858b0bddf4ada5f364a84ed60b196dbcda
firmware: dmi_scan: Fix UUID length safety check

The test which ensures that the DMI type 1 structure is long enough
to hold the UUID is off by one. It would fail if the structure is
exactly 24 bytes long, while that's sufficient to hold the UUID.

I don't expect this bug to cause problem in practice because all
implementations I have seen had length 8, 25 or 27 bytes, in line
with the SMBIOS specifications. But let's fix it still.

Signed-off-by: Jean Delvare <jdelvare@suse.de>
Fixes: a814c3597a6b ("firmware: dmi_scan: Check DMI structure length")
Reviewed-by: Mika Westerberg <mika.westerberg@linux.intel.com>
drivers/firmware/dmi_scan.c