]> git.baikalelectronics.ru Git - kernel.git/commit
watch_queue: Free the page array when watch_queue is dismantled
authorEric Dumazet <edumazet@google.com>
Mon, 28 Mar 2022 17:07:04 +0000 (18:07 +0100)
committerLinus Torvalds <torvalds@linux-foundation.org>
Sat, 2 Apr 2022 17:37:39 +0000 (10:37 -0700)
commit905f5c27e8d2abab71790e1f2c69d0e62fa3674d
treead020895463c1bc05edf1a1260349e4fda517235
parent0c1af6c19ef2ca3b1c7fa379da66e90fedae3dd2
watch_queue: Free the page array when watch_queue is dismantled

Commit 927e597d61c7 ("watch_queue: Free the alloc bitmap when the
watch_queue is torn down") took care of the bitmap, but not the page
array.

  BUG: memory leak
  unreferenced object 0xffff88810d9bc140 (size 32):
  comm "syz-executor335", pid 3603, jiffies 4294946994 (age 12.840s)
  hex dump (first 32 bytes):
    40 a7 40 04 00 ea ff ff 00 00 00 00 00 00 00 00  @.@.............
    00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00  ................
  backtrace:
     kmalloc_array include/linux/slab.h:621 [inline]
     kcalloc include/linux/slab.h:652 [inline]
     watch_queue_set_size+0x12f/0x2e0 kernel/watch_queue.c:251
     pipe_ioctl+0x82/0x140 fs/pipe.c:632
     vfs_ioctl fs/ioctl.c:51 [inline]
     __do_sys_ioctl fs/ioctl.c:874 [inline]
     __se_sys_ioctl fs/ioctl.c:860 [inline]
     __x64_sys_ioctl+0xfc/0x140 fs/ioctl.c:860
     do_syscall_x64 arch/x86/entry/common.c:50 [inline]

Reported-by: syzbot+25ea042ae28f3888727a@syzkaller.appspotmail.com
Fixes: a23d9805b5b3 ("pipe: Add general notification queue support")
Signed-off-by: Eric Dumazet <edumazet@google.com>
Signed-off-by: David Howells <dhowells@redhat.com>
Cc: Jann Horn <jannh@google.com>
Link: https://lore.kernel.org/r/20220322004654.618274-1-eric.dumazet@gmail.com/
Signed-off-by: Linus Torvalds <torvalds@linux-foundation.org>
kernel/watch_queue.c