]> git.baikalelectronics.ru Git - kernel.git/commit
staging: r8188eu: Use kzalloc() with GFP_ATOMIC in atomic context
authorFabio M. De Francesco <fmdefrancesco@gmail.com>
Mon, 1 Nov 2021 19:18:47 +0000 (20:18 +0100)
committerGreg Kroah-Hartman <gregkh@linuxfoundation.org>
Mon, 15 Nov 2021 09:22:34 +0000 (10:22 +0100)
commit903cd1b6dc9a4a0978681df4cf769f67f7b1d23a
tree23d5607c258777632830ed651697b436652a86b5
parenta91cda1b813406277c171d800a5b4135a683cb0c
staging: r8188eu: Use kzalloc() with GFP_ATOMIC in atomic context

Use the GFP_ATOMIC flag of kzalloc() with two memory allocation in
report_del_sta_event(). This function is called while holding spinlocks,
therefore it is not allowed to sleep. With the GFP_ATOMIC type flag, the
allocation is high priority and must not sleep.

This issue is detected by Smatch which emits the following warning:
"drivers/staging/r8188eu/core/rtw_mlme_ext.c:6848 report_del_sta_event()
warn: sleeping in atomic context".

After the change, the post-commit hook output the following message:
"CHECK: Prefer kzalloc(sizeof(*pcmd_obj)...) over
kzalloc(sizeof(struct cmd_obj)...)".

According to the above "CHECK", use the preferred style in the first
kzalloc().

Fixes: d8e6bb3b85ba ("staging: r8188eu: Remove wrappers for kalloc() and kzalloc()")
Fixes: 6d3f3f8a5f4a ("staging: r8188eu: introduce new core dir for RTL8188eu driver")
Signed-off-by: Fabio M. De Francesco <fmdefrancesco@gmail.com>
Link: https://lore.kernel.org/r/20211101191847.6749-1-fmdefrancesco@gmail.com
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Cc: stable <stable@vger.kernel.org>
drivers/staging/r8188eu/core/rtw_mlme_ext.c