]> git.baikalelectronics.ru Git - kernel.git/commit
net: phy: fix flag masking in __set_phy_supported
authorHeiner Kallweit <hkallweit1@gmail.com>
Tue, 3 Jul 2018 20:34:54 +0000 (22:34 +0200)
committerDavid S. Miller <davem@davemloft.net>
Thu, 5 Jul 2018 00:44:02 +0000 (09:44 +0900)
commit903863c88d41fe5369635fd9afafdbd2d6f80ad5
tree776a094275b9d4810d2ac9ee3345837d81459f14
parent3c957d8b0325118a8c83dad7ce08183c4a067dcd
net: phy: fix flag masking in __set_phy_supported

Currently also the pause flags are removed from phydev->supported because
they're not included in PHY_DEFAULT_FEATURES. I don't think this is
intended, especially when considering that this function can be called
via phy_set_max_speed() anywhere in a driver. Change the masking to mask
out only the values we're going to change. In addition remove the
misleading comment, job of this small function is just to adjust the
supported and advertised speeds.

Fixes: 8220d8aea7b2 ("phylib: Add phy_set_max_speed helper")
Signed-off-by: Heiner Kallweit <hkallweit1@gmail.com>
Reviewed-by: Andrew Lunn <andrew@lunn.ch>
Reviewed-by: Florian Fainelli <f.fainelli@gmail.com>
Signed-off-by: David S. Miller <davem@davemloft.net>
drivers/net/phy/phy_device.c