]> git.baikalelectronics.ru Git - kernel.git/commit
kernel/kmod.c: check for NULL in call_usermodehelper_exec()
authorTetsuo Handa <penguin-kernel@I-love.SAKURA.ne.jp>
Mon, 30 Sep 2013 20:45:08 +0000 (13:45 -0700)
committerLinus Torvalds <torvalds@linux-foundation.org>
Mon, 30 Sep 2013 21:31:02 +0000 (14:31 -0700)
commit8f5edd32b5f5ffcab4a59dd9dcef8384c32e9713
treed60639057e1d30c853330c513754d8e43f7306cb
parent76e11a8641b901b9ecff7a3f32862ad0c1f84d33
kernel/kmod.c: check for NULL in call_usermodehelper_exec()

If /proc/sys/kernel/core_pattern contains only "|", a NULL pointer
dereference happens upon core dump because argv_split("") returns
argv[0] == NULL.

This bug was once fixed by commit b6cf7e770843 ("usermodehelper: check
subprocess_info->path != NULL") but was by error reintroduced by commit
78f4fad3829e ("usermodehelper: kill the sub_info->path[0] check").

This bug seems to exist since 2.6.19 (the version which core dump to
pipe was added).  Depending on kernel version and config, some side
effect might happen immediately after this oops (e.g.  kernel panic with
2.6.32-358.18.1.el6).

Signed-off-by: Tetsuo Handa <penguin-kernel@I-love.SAKURA.ne.jp>
Acked-by: Oleg Nesterov <oleg@redhat.com>
Cc: <stable@vger.kernel.org>
Signed-off-by: Andrew Morton <akpm@linux-foundation.org>
Signed-off-by: Linus Torvalds <torvalds@linux-foundation.org>
kernel/kmod.c