]> git.baikalelectronics.ru Git - kernel.git/commit
genirq: Set IRQCHIP_SKIP_SET_WAKE for no_irq_chip
authorGeert Uytterhoeven <geert+renesas@glider.be>
Fri, 22 May 2015 07:58:49 +0000 (09:58 +0200)
committerThomas Gleixner <tglx@linutronix.de>
Fri, 22 May 2015 09:06:47 +0000 (11:06 +0200)
commit8f12bed3a6a8791427b95c457b0d7c930f60e5de
treee852d920e4b3cb53c23538f20505151f2ab01d5e
parent77bb943bdc270bf66f843f7d943650c7f5afe65e
genirq: Set IRQCHIP_SKIP_SET_WAKE for no_irq_chip

If no_irq_chip is used for wake up (e.g. gpio-keys with a simple GPIO
controller), the following warning is printed on resume from s2ram:

    WANING: CPU: 0 PID: 1046 at kernel/irq/manage.c:537 irq_set_irq_wake+0x9c/0xf8()
    Unbalanced IRQ 113 wake disable

This happens because no_irq_chip does not implement
irq_chip.irq_set_wake(), causing set_irq_wake_real() to return -ENXIO,
and irq_set_irq_wake() to reset the wake_depth to zero.

Set IRQCHIP_SKIP_SET_WAKE to indicate that irq_chip.irq_set_wake() is
not implemented.

Cfr. commit edbe147ac2594d53 ("genirq: Set IRQCHIP_SKIP_SET_WAKE flag
for dummy_irq_chip").

Signed-off-by: Geert Uytterhoeven <geert+renesas@glider.be>
Cc: Roger Quadros <rogerq@ti.com>
Cc: Gregory Clement <gregory.clement@free-electrons.com>
Link: http://lkml.kernel.org/r/1432281529-23325-1-git-send-email-geert%2Brenesas@glider.be
Signed-off-by: Thomas Gleixner <tglx@linutronix.de>
kernel/irq/dummychip.c