]> git.baikalelectronics.ru Git - kernel.git/commit
Revert "[media] lmed04: add missing breaks"
authorMauro Carvalho Chehab <mchehab@osg.samsung.com>
Tue, 25 Nov 2014 17:46:13 +0000 (15:46 -0200)
committerMauro Carvalho Chehab <mchehab@osg.samsung.com>
Wed, 26 Nov 2014 00:16:25 +0000 (22:16 -0200)
commit8ea48406ba34cb233a52ebdb01f3059ce943b1f1
tree2b266dc55f7b7c5ae77cbb0a94c4921dba350caa
parent73dfc46bf6b41c3ac94edc01eef14ed81e433f04
Revert "[media] lmed04: add missing breaks"

According with Malcolm, the missing breaks are intentional.

So, let's revert commit dffe6d1b29cb0345a62d15511bf66a534b93dbfd,
add some comments to document it and fix the two smatch warnings:

drivers/media/usb/dvb-usb-v2/lmedm04.c:828 lme_firmware_switch() warn: missing break? reassigning 'st->dvb_usb_lme2510_firmware'
drivers/media/usb/dvb-usb-v2/lmedm04.c:850 lme_firmware_switch() warn: missing break? reassigning 'st->dvb_usb_lme2510_firmware'

using a different strategy to avoid reassign values to
st->dvb_usb_lme2510_firmware.

Acked-by: Malcolm Priestley <tvboxspy@gmail.com>
Signed-off-by: Mauro Carvalho Chehab <mchehab@osg.samsung.com>
drivers/media/usb/dvb-usb-v2/lmedm04.c