]> git.baikalelectronics.ru Git - kernel.git/commit
rtw88: 8723d: fix incorrect setting of ldo_pwr
authorColin Ian King <colin.king@canonical.com>
Thu, 14 May 2020 18:13:29 +0000 (19:13 +0100)
committerKalle Valo <kvalo@codeaurora.org>
Mon, 18 May 2020 12:17:26 +0000 (15:17 +0300)
commit8e77a20a12874aa5a065bd067c25a495d86a6fae
treec9c8ad334e53d343d4e578d6ef870da302cc4d9d
parent9040a04a466d92924fcba6360de9b3d1dbbb422c
rtw88: 8723d: fix incorrect setting of ldo_pwr

Currently ldo_pwr has the LDO25 voltage bits set to zero and then
it is overwritten with the new voltage setting. The assignment
looks incorrect, it should be bit-wise or'ing in the new voltage
setting rather than a direct assignment.

Addresses-Coverity: ("Unused value")
Fixes: 419c4980693e ("rtw88: 8723d: Add cfg_ldo25 to control LDO25")
Signed-off-by: Colin Ian King <colin.king@canonical.com>
Acked-by: Ping-Ke Shih <pkshih@realtek.com>
Signed-off-by: Kalle Valo <kvalo@codeaurora.org>
Link: https://lore.kernel.org/r/20200514181329.16292-1-colin.king@canonical.com
drivers/net/wireless/realtek/rtw88/rtw8723d.c