]> git.baikalelectronics.ru Git - kernel.git/commit
drm/i915/gem: Comment on inability to check args.pad for MMAP_OFFSET
authorChris Wilson <chris@chris-wilson.co.uk>
Sat, 7 Dec 2019 22:26:44 +0000 (22:26 +0000)
committerChris Wilson <chris@chris-wilson.co.uk>
Mon, 9 Dec 2019 09:57:57 +0000 (09:57 +0000)
commit8d65859a4cbae92f441b9aec8780055a361cc3d0
treebb858257a58cff33034cce7cb17f203e1a5c1777
parentd63411000741ebca84b147b3e79cb6b298ee07e9
drm/i915/gem: Comment on inability to check args.pad for MMAP_OFFSET

Since we didn't check and insist that args.pad must be zero for MMAP_GTT
historically, we cannot insert a check now as old userspace may be
feeding in garbage. As such the lack of check is enshrined into the ABI,
so add a comment to remind us we cannot add the check later.

Signed-off-by: Chris Wilson <chris@chris-wilson.co.uk>
Cc: Joonas Lahtinen <joonas.lahtinen@linux.intel.com>
Reviewed-by: Joonas Lahtinen <joonas.lahtinen@linux.intel.com>
Link: https://patchwork.freedesktop.org/patch/msgid/20191207222644.2830129-1-chris@chris-wilson.co.uk
drivers/gpu/drm/i915/gem/i915_gem_mman.c