]> git.baikalelectronics.ru Git - kernel.git/commit
tipc: allow to build NACK message in link timeout function
authorTung Nguyen <tung.q.nguyen@dektech.com.au>
Tue, 21 Jul 2020 01:57:05 +0000 (08:57 +0700)
committerDavid S. Miller <davem@davemloft.net>
Tue, 21 Jul 2020 03:11:22 +0000 (20:11 -0700)
commit8d4a7a94ad5c29e68ab1a118b9ed7b65063e8348
tree10cb36c265ea8165979412c94902ff098fe55862
parent9957da4b42c4fe5f258b7461be0037456dcfa346
tipc: allow to build NACK message in link timeout function

Commit a64ad8240fc8 ("tipc: eliminate gap indicator from ACK messages")
eliminated sending of the 'gap' indicator in regular ACK messages and
only allowed to build NACK message with enabled probe/probe_reply.
However, necessary correction for building NACK message was missed
in tipc_link_timeout() function. This leads to significant delay and
link reset (due to retransmission failure) in lossy environment.

This commit fixes it by setting the 'probe' flag to 'true' when
the receive deferred queue is not empty. As a result, NACK message
will be built to send back to another peer.

Fixes: a64ad8240fc8 ("tipc: eliminate gap indicator from ACK messages")
Acked-by: Jon Maloy <jmaloy@redhat.com>
Signed-off-by: Tung Nguyen <tung.q.nguyen@dektech.com.au>
Signed-off-by: David S. Miller <davem@davemloft.net>
net/tipc/link.c