]> git.baikalelectronics.ru Git - kernel.git/commit
perf record: Rename variable to make code clear
authorWang Nan <wangnan0@huawei.com>
Mon, 23 May 2016 07:13:40 +0000 (07:13 +0000)
committerArnaldo Carvalho de Melo <acme@redhat.com>
Mon, 23 May 2016 21:22:47 +0000 (18:22 -0300)
commit8c74a960b4227beee3684590869511da9906c4b1
tree1221a34bf153698a5a97a9f8fc40d7bbc9909249
parente6ae0ad9b833a1d71d29f1fb974a7f3f39f512ff
perf record: Rename variable to make code clear

record__mmap_read() writes data from ring buffer into perf.data.  'head'
is maintained by the kernel, points to the last written record.
'old' is maintained by perf, points to the record read in previous
round. record__mmap_read() saves data from 'old' to 'head' to
perf.data.

The names of these variables are not very intutive. In addition,
when dealing with backward writing ring buffer, the md->prev pointer
should point to 'head' instead of the last byte it got.

Add 'start' and 'end' pointer to make code clear and set md->prev to
'head' instead of the moved 'old' pointer. This patch doesn't change
behavior since:

    buf = &data[old & md->mask];
    size = head - old;
    old += size;     <--- Here, old == head

Signed-off-by: Wang Nan <wangnan0@huawei.com>
Cc: Jiri Olsa <jolsa@kernel.org>
Cc: Masami Hiramatsu <masami.hiramatsu.pt@hitachi.com>
Cc: Namhyung Kim <namhyung@kernel.org>
Cc: Zefan Li <lizefan@huawei.com>
Cc: pi3orama@163.com
Link: http://lkml.kernel.org/r/1463987628-163563-4-git-send-email-wangnan0@huawei.com
Signed-off-by: He Kuang <hekuang@huawei.com>
Signed-off-by: Arnaldo Carvalho de Melo <acme@redhat.com>
tools/perf/builtin-record.c