]> git.baikalelectronics.ru Git - kernel.git/commit
ext4: add missing xattr hash update
authorTahsin Erdogan <tahsin@google.com>
Mon, 14 Aug 2017 12:30:06 +0000 (08:30 -0400)
committerTheodore Ts'o <tytso@mit.edu>
Mon, 14 Aug 2017 12:30:06 +0000 (08:30 -0400)
commit8c6c04dbde45ae635fa6730b9b7ea959525009f0
treeae4a63af40995527827573cc0aa921540727a22b
parent6965717fc35fad84672a93dca2cad4f15dfb98d2
ext4: add missing xattr hash update

When updating an extended attribute, if the padded value sizes are the
same, a shortcut is taken to avoid the bulk of the work. This was fine
until the xattr hash update was moved inside ext4_xattr_set_entry().
With that change, the hash update got missed in the shortcut case.

Thanks to ZhangYi (yizhang089@gmail.com) for root causing the problem.

Fixes: fcfc5b7d8ef7 ("ext4: eliminate xattr entry e_hash recalculation for removes")
Reported-by: Miklos Szeredi <miklos@szeredi.hu>
Signed-off-by: Tahsin Erdogan <tahsin@google.com>
Signed-off-by: Theodore Ts'o <tytso@mit.edu>
fs/ext4/xattr.c