]> git.baikalelectronics.ru Git - kernel.git/commit
b43: Fix error in cordic routine
authorLarry Finger <Larry.Finger@lwfinger.net>
Mon, 19 Nov 2018 18:01:24 +0000 (20:01 +0200)
committerKalle Valo <kvalo@codeaurora.org>
Thu, 29 Nov 2018 15:30:49 +0000 (17:30 +0200)
commit8b8a8b07309102cb9d4e595b488f2dd6ba666145
tree5851ebd19460bc38d848e10281c4d67dbd09b4a8
parent68d2e8e9da4dcffd905ae45114b324b8df68a029
b43: Fix error in cordic routine

The cordic routine for calculating sines and cosines that was added in
commit df70a196bf32 ("b43: update cordic code to match current specs")
contains an error whereby a quantity declared u32 can in fact go negative.

This problem was detected by Priit Laes who is switching b43 to use the
routine in the library functions of the kernel.

Fixes: 3b30abd0e0c7 ("b43: make cordic common (LP-PHY and N-PHY need it)")
Reported-by: Priit Laes <plaes@plaes.org>
Cc: Rafał Miłecki <zajec5@gmail.com>
Cc: Stable <stable@vger.kernel.org> # 2.6.34
Signed-off-by: Larry Finger <Larry.Finger@lwfinger.net>
Signed-off-by: Priit Laes <plaes@plaes.org>
Signed-off-by: Kalle Valo <kvalo@codeaurora.org>
drivers/net/wireless/broadcom/b43/phy_common.c