]> git.baikalelectronics.ru Git - kernel.git/commit
drm: kirin: Revert "Fix for hikey620 display offset problem"
authorJohn Stultz <john.stultz@linaro.org>
Tue, 3 Mar 2020 16:32:28 +0000 (16:32 +0000)
committerXinliang Liu <xinliang.liu@linaro.org>
Wed, 4 Mar 2020 13:29:05 +0000 (13:29 +0000)
commit8b62494f6ed85d81a918c7d73b78df6c7c3a73dc
tree5a239262a9abbcdbc8f6c839d6c5814756256ba0
parent4551e405c11c213a828c7ec879fe1ba1e04c9d04
drm: kirin: Revert "Fix for hikey620 display offset problem"

This reverts commit 5b1d2c0a2171189e72b8d27ff59dcfcb2165bfde.

With the commit 5b1d2c0a2171 ("drm: kirin: Fix for hikey620
display offset problem") we added support for handling LDI
overflows by resetting the hardware.

However, its been observed that when we do hit the LDI overflow
condition, the irq seems to be screaming, and we do nothing but
stream:
  [drm:ade_irq_handler [kirin_drm]] *ERROR* LDI underflow!
over and over to the screen

I've tried a few appraoches to avoid this, but none has yet
been successful and the cure here is worse then the original
disease, so revert this for now.

Cc: Xinliang Liu <xinliang.liu@linaro.org>
Cc: Rongrong Zou <zourongrong@gmail.com>
Cc: Xinwei Kong <kong.kongxinwei@hisilicon.com>
Cc: Chen Feng <puck.chen@hisilicon.com>
Cc: Sam Ravnborg <sam@ravnborg.org>
Cc: David Airlie <airlied@linux.ie>
Cc: Daniel Vetter <daniel@ffwll.ch>
Cc: dri-devel <dri-devel@lists.freedesktop.org>
Fixes: 5b1d2c0a2171 ("drm: kirin: Fix for hikey620 display offset problem")
Signed-off-by: John Stultz <john.stultz@linaro.org>
Acked-by: Xinliang Liu <xinliang.liu@linaro.org>
Signed-off-by: Xinliang Liu <xinliang.liu@linaro.org>
Link: https://patchwork.freedesktop.org/patch/msgid/20200303163228.52741-1-john.stultz@linaro.org
drivers/gpu/drm/hisilicon/kirin/kirin_ade_reg.h
drivers/gpu/drm/hisilicon/kirin/kirin_drm_ade.c