]> git.baikalelectronics.ru Git - kernel.git/commit
net: pcs: xpcs: propagate xpcs_read error to xpcs_get_state_c37_sgmii
authorVladimir Oltean <vladimir.oltean@nxp.com>
Wed, 20 Jul 2022 11:20:57 +0000 (14:20 +0300)
committerJakub Kicinski <kuba@kernel.org>
Fri, 22 Jul 2022 02:01:16 +0000 (19:01 -0700)
commit8acfdc0e40824c7fa061f1a2adf2936c4fb0333b
treedd6dda6fd2b01558a1df5e24a972e52ecc61ca8a
parent4b17ed32b0857ea514837709876a585907531a22
net: pcs: xpcs: propagate xpcs_read error to xpcs_get_state_c37_sgmii

While phylink_pcs_ops :: pcs_get_state does return void, xpcs_get_state()
does check for a non-zero return code from xpcs_get_state_c37_sgmii()
and prints that as a message to the kernel log.

However, a non-zero return code from xpcs_read() is translated into
"return false" (i.e. zero as int) and the I/O error is therefore not
printed. Fix that.

Fixes: 836cbf63391c ("net: pcs: add C37 SGMII AN support for intel mGbE controller")
Signed-off-by: Vladimir Oltean <vladimir.oltean@nxp.com>
Link: https://lore.kernel.org/r/20220720112057.3504398-1-vladimir.oltean@nxp.com
Signed-off-by: Jakub Kicinski <kuba@kernel.org>
drivers/net/pcs/pcs-xpcs.c