]> git.baikalelectronics.ru Git - kernel.git/commit
ipv4 igmp: use in_dev_put in timer handlers instead of __in_dev_put
authorSalam Noureddine <noureddine@aristanetworks.com>
Sun, 29 Sep 2013 20:39:42 +0000 (13:39 -0700)
committerDavid S. Miller <davem@davemloft.net>
Tue, 1 Oct 2013 05:28:56 +0000 (22:28 -0700)
commit8aa3daf7f8244c47f7713cd54fd5c95adbe8b42e
treef069b5c04468689ec87ef6cdf0e97054ae3dcb41
parent20da9c6f460daec7146ada847dcfb6172e4a356c
ipv4 igmp: use in_dev_put in timer handlers instead of __in_dev_put

It is possible for the timer handlers to run after the call to
ip_mc_down so use in_dev_put instead of __in_dev_put in the handler
function in order to do proper cleanup when the refcnt reaches 0.
Otherwise, the refcnt can reach zero without the in_device being
destroyed and we end up leaking a reference to the net_device and
see messages like the following,

unregister_netdevice: waiting for eth0 to become free. Usage count = 1

Tested on linux-3.4.43.

Signed-off-by: Salam Noureddine <noureddine@aristanetworks.com>
Signed-off-by: David S. Miller <davem@davemloft.net>
net/ipv4/igmp.c