]> git.baikalelectronics.ru Git - kernel.git/commit
bnxt_en: Need memory barrier when processing the completion ring.
authorMichael Chan <michael.chan@broadcom.com>
Wed, 4 May 2016 20:56:43 +0000 (16:56 -0400)
committerDavid S. Miller <davem@davemloft.net>
Wed, 4 May 2016 21:11:37 +0000 (17:11 -0400)
commit8a924fb0c3ca628342e5573d77cd53f1cb649643
treeba7439fac778de34a693ee7a3b0d446f70c5a8ba
parent3b053a712ccb038bee54c644d5bfdd847da29657
bnxt_en: Need memory barrier when processing the completion ring.

The code determines if the next ring entry is valid before proceeding
further to read the rest of the entry.  The CPU can re-order and read
the rest of the entry first, possibly reading a stale entry, if DMA
of a new entry happens right after reading it.  This issue can be
readily seen on a ppc64 system, causing it to crash.

Signed-off-by: Michael Chan <michael.chan@broadcom.com>
Signed-off-by: David S. Miller <davem@davemloft.net>
drivers/net/ethernet/broadcom/bnxt/bnxt.c