]> git.baikalelectronics.ru Git - kernel.git/commit
habanalabs/gaudi: fix incorrect MME offset calculation
authorKoby Elbaz <kelbaz@habana.ai>
Sun, 12 Jun 2022 19:16:25 +0000 (22:16 +0300)
committerOded Gabbay <ogabbay@kernel.org>
Tue, 12 Jul 2022 06:09:23 +0000 (09:09 +0300)
commit8a2feab084564f130fc76107bd9c064908e252e1
treefb9b43e4e8cfcdfde83ba21e43583fb123ee16bf
parent8e5d075bcdc75d331cb3d8418af6418cdf2a4eff
habanalabs/gaudi: fix incorrect MME offset calculation

Once FW raised an event following a MME2 QMAN error, the driver should
have gone to the corresponding status registers, trying to gather more
info on the error, yet it was accidentally accessing MME1 QMAN address
space.

Generally, we have x4 MMEs, while 0 & 2 are marked MASTER, and
1 & 3 are marked SLAVE. The former can be addressed, yet addressing
the latter is considered an access violation, and will result in a
hung system, which is what unintentionally happened above.
Note that this cannot happen in a secured system, since these registers
are protected with range registers.

Signed-off-by: Koby Elbaz <kelbaz@habana.ai>
Reviewed-by: Oded Gabbay <ogabbay@kernel.org>
Signed-off-by: Oded Gabbay <ogabbay@kernel.org>
drivers/misc/habanalabs/gaudi/gaudi.c