]> git.baikalelectronics.ru Git - kernel.git/commit
ALSA: pcm: Fix mutex unbalance in OSS emulation ioctls
authorTakashi Iwai <tiwai@suse.de>
Tue, 27 Mar 2018 12:32:23 +0000 (14:32 +0200)
committerTakashi Iwai <tiwai@suse.de>
Tue, 27 Mar 2018 14:20:02 +0000 (16:20 +0200)
commit8a24d50b46b4223df65cd417b1ae30650f6dd14e
treea270d39499d36075969c0a709a1a00a0d8d9d966
parentc4eadf037ffb5a733260e2eb4c0adacbbfe370d2
ALSA: pcm: Fix mutex unbalance in OSS emulation ioctls

The previous fix fe32bc9f1f60 ("ALSA: pcm: Return -EBUSY for OSS
ioctls changing busy streams") introduced some mutex unbalance; the
check of runtime->oss.rw_ref was inserted in a wrong place after the
mutex lock.

This patch fixes the inconsistency by rewriting with the helper
functions to lock/unlock parameters with the stream check.

Fixes: fe32bc9f1f60 ("ALSA: pcm: Return -EBUSY for OSS ioctls changing busy streams")
Reported-by: Dan Carpenter <dan.carpenter@oracle.com>
Cc: <stable@vger.kernel.org>
Signed-off-by: Takashi Iwai <tiwai@suse.de>
sound/core/oss/pcm_oss.c