]> git.baikalelectronics.ru Git - kernel.git/commit
ipv6: Revert "ipv6: Allow non-gateway ECMP for IPv6"
authorIdo Schimmel <idosch@mellanox.com>
Wed, 2 May 2018 19:41:56 +0000 (22:41 +0300)
committerDavid S. Miller <davem@davemloft.net>
Wed, 2 May 2018 20:33:02 +0000 (16:33 -0400)
commit89c06b24053a0bed59f1ad81ea115a0b5eb4b99e
tree062c2d521125bed978582d9f4e6d46987f1ce019
parent7806225fcfc0760edcaa56d7c19b72f5d6a6d685
ipv6: Revert "ipv6: Allow non-gateway ECMP for IPv6"

This reverts commit cb79dd3d5ee2 ("ipv6: Allow non-gateway ECMP for
IPv6").

Eric reported a division by zero in rt6_multipath_rebalance() which is
caused by above commit that considers identical local routes to be
siblings. The division by zero happens because a nexthop weight is not
set for local routes.

Revert the commit as it does not fix a bug and has side effects.

To reproduce:

# ip -6 address add 2001:db8::1/64 dev dummy0
# ip -6 address add 2001:db8::1/64 dev dummy1

Fixes: cb79dd3d5ee2 ("ipv6: Allow non-gateway ECMP for IPv6")
Signed-off-by: Ido Schimmel <idosch@mellanox.com>
Reported-by: Eric Dumazet <eric.dumazet@gmail.com>
Tested-by: Eric Dumazet <edumazet@google.com>
Signed-off-by: David S. Miller <davem@davemloft.net>
include/net/ip6_route.h
net/ipv6/ip6_fib.c