]> git.baikalelectronics.ru Git - kernel.git/commit
USB: FHCI: cq_get() should check kfifo_out()'s return value
authorAnton Vorontsov <avorontsov@mvista.com>
Fri, 14 May 2010 14:33:18 +0000 (18:33 +0400)
committerGreg Kroah-Hartman <gregkh@suse.de>
Thu, 20 May 2010 20:21:46 +0000 (13:21 -0700)
commit89a4fa46d909785c7e186b1e34881072e6eb6754
tree8f97a2d5879b9c7e130372552a2b42b239e97d59
parent9573747eef64a4c5d407b8d2958ac267b0030d2a
USB: FHCI: cq_get() should check kfifo_out()'s return value

Since commit ca6027e92764cf8d393f087225abfdbb92759e73 ("kfifo: rename
kfifo_put... into kfifo_in... and kfifo_get... into kfifo_out..."),
kfifo_out() is marked __must_check, and that causes gcc to produce
lots of warnings like this:

  CC      drivers/usb/host/fhci-mem.o
In file included from drivers/usb/host/fhci-hcd.c:34:
drivers/usb/host/fhci.h: In function 'cq_get':
drivers/usb/host/fhci.h:520: warning: ignoring return value of 'kfifo_out', declared with attribute warn_unused_result
...

This patch fixes the issue by properly checking the return value.

Signed-off-by: Anton Vorontsov <avorontsov@mvista.com>
Cc: stable <stable@kernel.org> [.33 and .34]
Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de>
drivers/usb/host/fhci.h