]> git.baikalelectronics.ru Git - kernel.git/commit
KVM: Prevent module exit until all VMs are freed
authorDavid Matlack <dmatlack@google.com>
Thu, 3 Mar 2022 18:33:27 +0000 (18:33 +0000)
committerPaolo Bonzini <pbonzini@redhat.com>
Tue, 29 Mar 2022 17:02:25 +0000 (13:02 -0400)
commit87cf79539c74b7010aa8f5be0742d19142a4a7b8
tree5b7d3415996259b5f6eea3e98cf88cddd618acf7
parent86478b53dcbe905c477eea96cc408c3bca3cd221
KVM: Prevent module exit until all VMs are freed

Tie the lifetime the KVM module to the lifetime of each VM via
kvm.users_count. This way anything that grabs a reference to the VM via
kvm_get_kvm() cannot accidentally outlive the KVM module.

Prior to this commit, the lifetime of the KVM module was tied to the
lifetime of /dev/kvm file descriptors, VM file descriptors, and vCPU
file descriptors by their respective file_operations "owner" field.
This approach is insufficient because references grabbed via
kvm_get_kvm() do not prevent closing any of the aforementioned file
descriptors.

This fixes a long standing theoretical bug in KVM that at least affects
async page faults. kvm_setup_async_pf() grabs a reference via
kvm_get_kvm(), and drops it in an asynchronous work callback. Nothing
prevents the VM file descriptor from being closed and the KVM module
from being unloaded before this callback runs.

Fixes: 62cd8956f013 ("KVM: Halt vcpu if page it tries to access is swapped out")
Fixes: 2c67e1ebd8d0 ("KVM: set owner of cpu and vm file operations")
Cc: stable@vger.kernel.org
Suggested-by: Ben Gardon <bgardon@google.com>
[ Based on a patch from Ben implemented for Google's kernel. ]
Signed-off-by: David Matlack <dmatlack@google.com>
Message-Id: <20220303183328.1499189-2-dmatlack@google.com>
Signed-off-by: Paolo Bonzini <pbonzini@redhat.com>
virt/kvm/kvm_main.c