]> git.baikalelectronics.ru Git - kernel.git/commit
arm64: Cortex-A53 errata workaround: check for kernel addresses
authorAndre Przywara <andre.przywara@arm.com>
Wed, 19 Oct 2016 13:40:54 +0000 (14:40 +0100)
committerWill Deacon <will.deacon@arm.com>
Thu, 20 Oct 2016 08:50:49 +0000 (09:50 +0100)
commit87261d19046aeaeed8eb3d2793fde850ae1b5c9e
tree5e27605b4c18c29fbc1307d92bc1ef30e4ab6883
parent1e6e57d9b34a9075d5f9e2048ea7b09756590d11
arm64: Cortex-A53 errata workaround: check for kernel addresses

Commit 7dd01aef0557 ("arm64: trap userspace "dc cvau" cache operation on
errata-affected core") adds code to execute cache maintenance instructions
in the kernel on behalf of userland on CPUs with certain ARM CPU errata.
It turns out that the address hasn't been checked to be a valid user
space address, allowing userland to clean cache lines in kernel space.
Fix this by introducing an address check before executing the
instructions on behalf of userland.

Since the address doesn't come via a syscall parameter, we can't just
reject tagged pointers and instead have to remove the tag when checking
against the user address limit.

Cc: <stable@vger.kernel.org>
Fixes: 7dd01aef0557 ("arm64: trap userspace "dc cvau" cache operation on errata-affected core")
Reported-by: Kristina Martsenko <kristina.martsenko@arm.com>
Signed-off-by: Andre Przywara <andre.przywara@arm.com>
[will: rework commit message + replace access_ok with max_user_addr()]
Signed-off-by: Will Deacon <will.deacon@arm.com>
arch/arm64/include/asm/uaccess.h
arch/arm64/kernel/traps.c