]> git.baikalelectronics.ru Git - kernel.git/commit
net: stmmac: disable Split Header (SPH) for Intel platforms
authorTan Tee Min <tee.min.tan@linux.intel.com>
Fri, 29 Apr 2022 11:58:07 +0000 (19:58 +0800)
committerDavid S. Miller <davem@davemloft.net>
Sun, 1 May 2022 12:20:03 +0000 (13:20 +0100)
commit86f5b60e85d9616720e93fd3fdc556d79e5a5273
treef1befd2a2c891278284f322e6b1c74fc60227865
parent25f7d95c352cac9f863963b7643bb24a4f92f106
net: stmmac: disable Split Header (SPH) for Intel platforms

Based on DesignWare Ethernet QoS datasheet, we are seeing the limitation
of Split Header (SPH) feature is not supported for Ipv4 fragmented packet.
This SPH limitation will cause ping failure when the packets size exceed
the MTU size. For example, the issue happens once the basic ping packet
size is larger than the configured MTU size and the data is lost inside
the fragmented packet, replaced by zeros/corrupted values, and leads to
ping fail.

So, disable the Split Header for Intel platforms.

v2: Add fixes tag in commit message.

Fixes: 5c73dc61d53a("net: stmmac: Add Split Header support and enable it in XGMAC cores")
Cc: <stable@vger.kernel.org> # 5.10.x
Suggested-by: Ong, Boon Leong <boon.leong.ong@intel.com>
Signed-off-by: Mohammad Athari Bin Ismail <mohammad.athari.ismail@intel.com>
Signed-off-by: Wong Vee Khee <vee.khee.wong@linux.intel.com>
Signed-off-by: Tan Tee Min <tee.min.tan@linux.intel.com>
Signed-off-by: David S. Miller <davem@davemloft.net>
drivers/net/ethernet/stmicro/stmmac/dwmac-intel.c
drivers/net/ethernet/stmicro/stmmac/stmmac_main.c
include/linux/stmmac.h