]> git.baikalelectronics.ru Git - kernel.git/commit
atm: firestream: add more reserved strings
authorDan Carpenter <dan.carpenter@oracle.com>
Fri, 27 May 2016 10:33:50 +0000 (13:33 +0300)
committerDavid S. Miller <davem@davemloft.net>
Tue, 31 May 2016 18:52:59 +0000 (11:52 -0700)
commit86f04396ff6d36146ec335d429191a7c8e2209af
tree408c471f3814b80728aaca8d197b78cc9861fbe4
parentce577668a426c6a9e2470a09dcd07fbd6e45272a
atm: firestream: add more reserved strings

This bug was there when the driver was first added in back in year 2000.
It causes a Smatch warning:

    drivers/atm/firestream.c:849 process_incoming()
    error: buffer overflow 'res_strings' 60 <= 63

There are supposed to be 64 entries in this array and the missing
strings are clearly in the 30 40 range.  I added them as reserved 37 to
reserved 40.  It's possible that strings are really supposed to be added
in the middle instead of at the end, but this approach is safe, in that
it fixes the bug and doesn't break anything that wasn't already broken.

Signed-off-by: Dan Carpenter <dan.carpenter@oracle.com>
Signed-off-by: David S. Miller <davem@davemloft.net>
drivers/atm/firestream.c