]> git.baikalelectronics.ru Git - kernel.git/commit
sch_cake: fix srchost/dsthost hashing mode
authorToke Høiland-Jørgensen <toke@redhat.com>
Mon, 16 Aug 2021 11:59:17 +0000 (13:59 +0200)
committerDavid S. Miller <davem@davemloft.net>
Wed, 18 Aug 2021 09:14:00 +0000 (10:14 +0100)
commit86b9bbd332d0510679c7fedcee3e3bd278be5756
treec2dc5533ad58e28295520e6e281ae26dc6979670
parent1b80fec7b043552e01609bae7d0aad07aa742adc
sch_cake: fix srchost/dsthost hashing mode

When adding support for using the skb->hash value as the flow hash in CAKE,
I accidentally introduced a logic error that broke the host-only isolation
modes of CAKE (srchost and dsthost keywords). Specifically, the flow_hash
variable should stay initialised to 0 in cake_hash() in pure host-based
hashing mode. Add a check for this before using the skb->hash value as
flow_hash.

Fixes: b0c19ed6088a ("sch_cake: Take advantage of skb->hash where appropriate")
Reported-by: Pete Heist <pete@heistp.net>
Tested-by: Pete Heist <pete@heistp.net>
Signed-off-by: Toke Høiland-Jørgensen <toke@redhat.com>
Signed-off-by: David S. Miller <davem@davemloft.net>
net/sched/sch_cake.c